drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #1025: DRILL-5936: Refactor MergingRecordBatch based on c...
Date Fri, 10 Nov 2017 20:57:31 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1025#discussion_r150335985
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
    @@ -795,6 +788,8 @@ private void generateComparisons(final ClassGenerator<?> g,
final VectorAccessib
        * @param node Reference to the next record to copy from the incoming batches
        */
       private boolean copyRecordToOutgoingBatch(final Node node) {
    +    assert outgoingPosition < OUTGOING_BATCH_SIZE
    --- End diff --
    
    Ok.  Updated changes lgtm. 


---

Mime
View raw message