drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] drill pull request #1025: DRILL-5936: Refactor MergingRecordBatch based on c...
Date Fri, 10 Nov 2017 20:06:49 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1025#discussion_r150326663
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
    @@ -177,11 +177,11 @@ public IterOutcome innerNext() {
         }
         boolean schemaChanged = false;
     
    -    if (prevBatchWasFull) {
    +    if (!prevBatchNotFull) {
    --- End diff --
    
    @amansinha100 Addressed minor comment, please review delta and I'll squash it.


---

Mime
View raw message