drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...
Date Fri, 10 Nov 2017 19:45:53 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1023#discussion_r150322554
  
    --- Diff: pom.xml ---
    @@ -442,7 +442,7 @@
                   -Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTransformer.scalar_replacement=on"
                   -Ddrill.test.query.printing.silent=true
                   -Ddrill.catastrophic_to_standard_out=true
    -              -XX:MaxPermSize=512M -XX:MaxDirectMemorySize=3072M
    +              -XX:MaxPermSize=512M -XX:MaxDirectMemorySize=4096M
    --- End diff --
    
    DRILL-5926 affects not only this PR but my PR  #1031 as well even though they are not
related at all. At a minimum the change should be in a separate commit that refers to DRILL-5926
as it is a workaround and not an actual fix for the problem. In the future, the workaround
may need to be reverted and if it is mixed with other changes, it will not be clear what needs
to be reverted. Note that with other changes I would expect tests to require less memory,
not more.


---

Mime
View raw message