drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...
Date Thu, 09 Nov 2017 20:17:55 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r150073945
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSet.java ---
    @@ -85,8 +85,7 @@
        * new row set with the updated columns, then merge the new
        * and old row sets to create a new immutable row set.
        */
    -
    -  public interface RowSetWriter extends TupleWriter {
    +  interface RowSetWriter extends TupleWriter {
    --- End diff --
    
    Aren't nested interfaces `protected` by default? Just had to change one from default to
`public` so I could use it in another package...


---

Mime
View raw message