drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akumarb2010 <...@git.apache.org>
Subject [GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin
Date Thu, 09 Nov 2017 15:55:35 GMT
Github user akumarb2010 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1027#discussion_r150002516
  
    --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/DrillKafkaConfig.java
---
    @@ -0,0 +1,31 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.kafka;
    +
    +public class DrillKafkaConfig {
    +
    +  /**
    +   * Timeout for fetching messages from Kafka
    --- End diff --
    
    Thanks Paul, this is very good point and it perfectly make sense to add them as Drill
session options instead of Drill config properties. We are working on these changes.


---

Mime
View raw message