drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...
Date Wed, 08 Nov 2017 00:15:30 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r149542622
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
    @@ -239,6 +261,11 @@ QueryDataBatch getNext() throws UserException, InterruptedException
{
                 }
                 return qdb;
               }
    +
    +          // Check and throw SQLTimeoutException
    +          if ( parent.timeoutInMilliseconds > 0 && parent.elapsedTimer.elapsed(TimeUnit.SECONDS)
>= parent.timeoutInMilliseconds ) {
    --- End diff --
    
    wrong unit for the comparison (should be millis)


---

Mime
View raw message