drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...
Date Tue, 07 Nov 2017 19:25:14 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r149477233
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java ---
    @@ -61,55 +71,129 @@ public static void tearDownStatement() throws SQLException {
       //////////
       // getQueryTimeout():
     
    -  /** Tests that getQueryTimeout() indicates no timeout set. */
    +  /**
    +   * Test for reading of default query timeout
    +   */
       @Test
    -  public void testGetQueryTimeoutSaysNoTimeout() throws SQLException {
    -    assertThat( statement.getQueryTimeout(), equalTo( 0 ) );
    +  public void testDefaultGetQueryTimeout() throws SQLException {
    +    Statement stmt = connection.createStatement();
    +    int timeoutValue = stmt.getQueryTimeout();
    +    assert( 0 == timeoutValue );
    --- End diff --
    
    +1 


---

Mime
View raw message