drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...
Date Tue, 07 Nov 2017 19:25:10 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r149477222
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
    @@ -237,6 +245,127 @@ public String toString() {
         }
       }
     
    +  /**
    +   * Test for reading of default query timeout
    +   */
    +  @Test
    +  public void testDefaultGetQueryTimeout() throws SQLException {
    +    PreparedStatement stmt = connection.prepareStatement(SYS_VERSION_SQL);
    +    int timeoutValue = stmt.getQueryTimeout();
    +    assert( 0 == timeoutValue );
    +  }
    +
    +  /**
    +   * Test Invalid parameter by giving negative timeout
    +   */
    +  @Test ( expected = InvalidParameterSqlException.class )
    +  public void testInvalidSetQueryTimeout() throws SQLException {
    +    PreparedStatement stmt = connection.prepareStatement(SYS_VERSION_SQL);
    +    //Setting negative value
    +    int valueToSet = -10;
    +    if (0L == valueToSet) {
    +      valueToSet--;
    +    }
    +    try {
    +      stmt.setQueryTimeout(valueToSet);
    +    } catch ( final Exception e) {
    +      // TODO: handle exception
    +      assertThat( e.getMessage(), containsString( "illegal timeout value") );
    +      //Converting this to match expected Exception
    +      throw new InvalidParameterSqlException(e.getMessage());
    --- End diff --
    
    but you did since you catch the exception and do a check on the message. Rewrapping it
so that the test framework can check the new type has no value.


---

Mime
View raw message