drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...
Date Tue, 07 Nov 2017 19:13:59 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r149473999
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
    @@ -96,6 +117,13 @@ private void throwIfClosed() throws AlreadyClosedSqlException,
             throw new AlreadyClosedSqlException( "ResultSet is already closed." );
           }
         }
    +
    +    //Query Timeout Check. The timer has already been started by the DrillCursor at this
point
    --- End diff --
    
    This code block gets touched even if there is no timeout set, hence the check to implicitly
confirm if there is a timeout set.


---

Mime
View raw message