drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #904: DRILL-5717: change some date time test cases with s...
Date Tue, 07 Nov 2017 17:21:11 GMT
Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/904#discussion_r149440392
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
    @@ -225,4 +243,16 @@ public void testPostgresDateFormatError() throws Exception {
           throw e;
         }
       }
    +
    +  /**
    +   * mock current locale to US
    +   */
    +  private void mockUSLocale() {
    --- End diff --
    
    Please move this method into ExecTest class and make it public and static.


---

Mime
View raw message