drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill issue #1021: DRILL-5923: Display name for query state
Date Tue, 07 Nov 2017 11:02:32 GMT
Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1021
  
    @prasadns14 as far as I understood, you made all these changes to replace `completed`
with `succeeded`. What if you just make changes in State enum itself, refactor some code and
thus no changes in rest part will be required? 
    From UserBitShared.proto
    ```
    	enum QueryState {
    	  STARTING = 0; // query has been scheduled for execution. This is post-enqueued.
    	  RUNNING = 1;
    	  COMPLETED = 2; // query has completed successfully
    	  CANCELED = 3; // query has been cancelled, and all cleanup is complete
    	  FAILED = 4;
    	  CANCELLATION_REQUESTED = 5; // cancellation has been requested, and is being processed
    	  ENQUEUED = 6; // query has been enqueued. this is pre-starting.
    	}
    ```
    After the renaming, please don't forget to regenerate protobuf.


---

Mime
View raw message