drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...
Date Tue, 07 Nov 2017 06:10:53 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r149277808
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ---
    @@ -237,6 +245,127 @@ public String toString() {
         }
       }
     
    +  /**
    +   * Test for reading of default query timeout
    +   */
    +  @Test
    +  public void testDefaultGetQueryTimeout() throws SQLException {
    +    PreparedStatement stmt = connection.prepareStatement(SYS_VERSION_SQL);
    --- End diff --
    
    statements should be closed: easy to do with a `try(resource) { }` construct (valid for
all test cases)


---

Mime
View raw message