drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Date Tue, 07 Nov 2017 05:37:55 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r149228776
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java ---
    @@ -34,11 +35,11 @@
        *            if connection is closed
        */
       @Override
    -  int getQueryTimeout() throws AlreadyClosedSqlException;
    +  int getQueryTimeout() throws AlreadyClosedSqlException, SQLException;
     
       /**
        * <strong>Drill</strong>:
    -   * Not supported (for non-zero timeout value).
    +   * Supported (for non-zero timeout value).
        * <p>
        *   Normally, just throws {@link SQLFeatureNotSupportedException} unless
    --- End diff --
    
    need to update javadoc description


---

Mime
View raw message