drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Date Tue, 07 Nov 2017 05:37:55 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r149274508
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java
---
    @@ -552,16 +701,22 @@ public void clearParameters() throws SQLException {
       public boolean execute() throws SQLException {
         throwIfClosed();
         try {
    +      if (timeoutTrigger != null) {
    +        timeoutTriggerHandle = timeoutTrigger.startCountdown();
    +      }
           return super.execute();
         }
         catch (UnsupportedOperationException e) {
    +      if ( isTimedOut() ) {
    --- End diff --
    
    i'm not sure it makes sense to check it query timed out if operation is unsupported


---

Mime
View raw message