drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dvjyothsna <...@git.apache.org>
Subject [GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit
Date Mon, 06 Nov 2017 19:58:26 GMT
Github user dvjyothsna commented on a diff in the pull request:

    https://github.com/apache/drill/pull/921#discussion_r149186401
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
---
    @@ -348,6 +354,21 @@ public void run() {
          */
       }
     
    +  /*
    +    Check if the foreman is ONLINE. If not dont accept any new queries.
    +   */
    +  public void checkForemanState() throws ForemanException{
    +    DrillbitEndpoint foreman = drillbitContext.getEndpoint();
    +    Collection<DrillbitEndpoint> dbs = drillbitContext.getAvailableBits();
    --- End diff --
    
    DrillbitEndPoint is protobuf generated code so I cannot modify that. Can I add isOnline()
method in foreman or a new Class ?


---

Mime
View raw message