drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin
Date Sat, 04 Nov 2017 16:00:39 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/774#discussion_r148934194
  
    --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/Constants.java
---
    @@ -0,0 +1,32 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.openTSDB;
    +
    +public interface Constants {
    +  /**
    +   * openTSDB required constants for API call
    +   */
    +  public static final String DEFAULT_TIME = "47y-ago";
    --- End diff --
    
    Since we agreed that we won't allow defaults, why do we still have these two constants?
I also have noticed they are used in the code below...


---

Mime
View raw message