drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bitblender <...@git.apache.org>
Subject [GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit
Date Fri, 03 Nov 2017 19:38:13 GMT
Github user bitblender commented on a diff in the pull request:

    https://github.com/apache/drill/pull/921#discussion_r148684246
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
    @@ -70,7 +72,10 @@
       private final CountDownLatch initialConnection = new CountDownLatch(1);
       private final TransientStoreFactory factory;
       private ServiceCache<DrillbitEndpoint> serviceCache;
    +  private DrillbitEndpoint endpoint;
     
    +//private HashMap<MultiKey, DrillbitEndpoint> endpointsMap = new HashMap<MultiKey,
DrillbitEndpoint>();
    +  private ConcurrentHashMap<MultiKey, DrillbitEndpoint> endpointsMap = new ConcurrentHashMap<MultiKey,DrillbitEndpoint>();
    --- End diff --
    
    please add a comment about what this map contains. 


---

Mime
View raw message