Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: Timothy Farkas <tfarkas@mapr.com>
To: "dev@drill.apache.org" <dev@drill.apache.org>
Subject: Re: Excessive review comments
Thread-Topic: Excessive review comments
Thread-Index: AQHTSHTnhpOpX/bU00CgC7eS+U0dHqLrTJKAgAACQ4CAABMGAIAAAQTx
Date: Thu, 19 Oct 2017 16:51:06 +0000
Message-ID: <SN1PR16MB0384D6D5274E49F70688BD65C3420@SN1PR16MB0384.namprd16.prod.outlook.com>
References: <git-pr-984-drill@git.apache.org>
 <20171018223644.D4D6EDFAE1@git1-us-west.apache.org>
 <D81EB23B-768F-473B-91E1-150F619045F1@mapr.com>
 <5B687867-7A37-425D-A799-51158AE1860D@apache.org>
 <CAC1ju50=h+Mk7Gdhjk-y38JvRoHU5YgYnvLLx2dCgn=bLmk-JA@mail.gmail.com>,<4A2AA6E9-FDB5-4A10-AE6D-675AAFBE739C@mapr.com>
In-Reply-To: <4A2AA6E9-FDB5-4A10-AE6D-675AAFBE739C@mapr.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: mapr.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_SN1PR16MB0384D6D5274E49F70688BD65C3420SN1PR16MB0384namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2017 16:51:06.8900
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2573c0c8-6f2a-4418-a58a-a742cf6415fb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR16MB0382
archived-at: Thu, 19 Oct 2017 16:51:19 -0000

--_000_SN1PR16MB0384D6D5274E49F70688BD65C3420SN1PR16MB0384namp_
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable

+1 for turning off the feature. If someone really needs to be emailed with =
comment updates they can become a watcher of the repo on Github.

________________________________
From: Paul Rogers <progers@mapr.com>
Sent: Thursday, October 19, 2017 9:43:26 AM
To: dev@drill.apache.org
Subject: Re: Excessive review comments

Can we simply turn off the feature? I never, ever read the e-mails coming f=
rom this source; I always follow the link back to the PR. Can we reduce it =
to =93Hey, just wanted to let you know that a new comment was posted. Click=
 _here_ to read it.=94

The only other solution is to give few review comments; not sure if we want=
 to go that route...

- Paul

> On Oct 19, 2017, at 8:35 AM, Arina Yelchiyeva <arina.yelchiyeva@gmail.com=
> wrote:
>
> Agree, I am not sure I saw this feature working as well.
> All it did it was sending all the emails at once, rather in the process o=
f
> comments emergence.
>
> Kind regards
> Arina
>
> On Thu, Oct 19, 2017 at 6:27 PM, Julian Hyde <jhyde@apache.org> wrote:
>
>> I don=92t know whether anything is broken. I believed that the GitHub =
=93start
>> a review=94 feature would cause all review comments to be sent in a sing=
le
>> email. But now I think of it, I=92m not sure I ever saw it working. I wo=
nder
>> whether Github-ASF integration is at fault.
>>
>> Whatever the reasons for it, 39 emails to dev list is quite a blast.
>> People tend to unsubscribe from lists if the volume is too high.
>>
>> Julian
>>
>>
>>> On Oct 18, 2017, at 5:54 PM, Paul Rogers <progers@mapr.com> wrote:
>>>
>>> With all due respect, I did start a review. Is something broken?
>>>
>>> - Paul
>>>
>>>> On Oct 18, 2017, at 3:36 PM, julianhyde <git@git.apache.org> wrote:
>>>>
>>>> Github user julianhyde commented on a diff in the pull request:
>>>>
>>>>  https://github.com/apache/drill/pull/984#discussion_r145561518
>>>>
>>>>  --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterF=
ixture.java
>> ---
>>>>  @@ -584,11 +492,14 @@ public static void defineWorkspace(Drillbit
>> drillbit, String pluginName,
>>>>     public static final String EXPLAIN_PLAN_TEXT =3D "text";
>>>>     public static final String EXPLAIN_PLAN_JSON =3D "json";
>>>>
>>>>  -  public static FixtureBuilder builder() {
>>>>  -    FixtureBuilder builder =3D new FixtureBuilder()
>>>>  +  public static FixtureBuilder builder(DirTestWatcher
>> dirTestWatcher) {
>>>>  --- End diff --
>>>>
>>>>  Jeez Paul, please start a review rather than making single review
>> comments. I just got 39 emails from you, and so did everyone else on
>> dev@drill.
>>>>
>>>>
>>>> ---
>>>
>>
>>


--_000_SN1PR16MB0384D6D5274E49F70688BD65C3420SN1PR16MB0384namp_--