Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: arina-ielchiieva <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-774-drill@git.apache.org>
In-Reply-To: <git-pr-774-drill@git.apache.org>
Subject: [GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin
Content-Type: text/plain
Message-Id: <20171030132446.7FF7EDFFB3@git1-us-west.apache.org>
Date: Mon, 30 Oct 2017 13:24:46 +0000 (UTC)
archived-at: Mon, 30 Oct 2017 13:24:51 -0000

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/774#discussion_r146134351
  
    --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/services/ServiceImpl.java ---
    @@ -0,0 +1,176 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.openTSDB.client.services;
    +
    +import org.apache.drill.exec.store.openTSDB.client.OpenTSDB;
    +import org.apache.drill.exec.store.openTSDB.client.OpenTSDBTypes;
    +import org.apache.drill.exec.store.openTSDB.client.Service;
    +import org.apache.drill.exec.store.openTSDB.client.query.DBQuery;
    +import org.apache.drill.exec.store.openTSDB.client.query.Query;
    +import org.apache.drill.exec.store.openTSDB.dto.ColumnDTO;
    +import org.apache.drill.exec.store.openTSDB.dto.MetricDTO;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import retrofit2.Retrofit;
    +import retrofit2.converter.jackson.JacksonConverterFactory;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import static org.apache.drill.exec.store.openTSDB.Constants.AGGREGATOR;
    +import static org.apache.drill.exec.store.openTSDB.Constants.DOWNSAMPLE;
    +import static org.apache.drill.exec.store.openTSDB.Constants.METRIC;
    +import static org.apache.drill.exec.store.openTSDB.Util.isTableNameValid;
    +import static org.apache.drill.exec.store.openTSDB.Util.parseFROMRowData;
    +
    +public class ServiceImpl implements Service {
    +
    +  private static final Logger log =
    +      LoggerFactory.getLogger(ServiceImpl.class);
    +
    +  private OpenTSDB client;
    --- End diff --
    
    final?


---