Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: vrozov <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-1013-drill@git.apache.org>
In-Reply-To: <git-pr-1013-drill@git.apache.org>
Subject: [GitHub] drill pull request #1013: DRILL-5910: Add factory name to ClassNotFoundExcep...
Content-Type: text/plain
Message-Id: <20171027154237.10232DFB6F@git1-us-west.apache.org>
Date: Fri, 27 Oct 2017 15:42:37 +0000 (UTC)
archived-at: Fri, 27 Oct 2017 15:42:39 -0000

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1013#discussion_r147445561
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java ---
    @@ -57,17 +57,17 @@ private ClientAuthenticatorProvider() {
     
         // then, custom factories
         if (customFactories != null) {
    -      try {
    -        final String[] factories = customFactories.split(",");
    -        for (final String factory : factories) {
    +      final String[] factories = customFactories.split(",");
    +      for (final String factory : factories) {
    +        try {
               final Class<?> clazz = Class.forName(factory);
               if (AuthenticatorFactory.class.isAssignableFrom(clazz)) {
                 final AuthenticatorFactory instance = (AuthenticatorFactory) clazz.newInstance();
                 authFactories.put(instance.getSimpleName(), instance);
               }
    +        } catch (final ClassNotFoundException | IllegalAccessException | InstantiationException e) {
    +          throw new DrillRuntimeException(String.format("Failed to create auth factory '%s'", factory), e);
    --- End diff --
    
    Not directly related to this PR, but should it continue with the default set of factories if one of custom factories can't be instantiated?


---