Return-Path: <dev-return-32877-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 5A8AB200D37
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 26 Oct 2017 00:56:05 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 5911B160BE0; Wed, 25 Oct 2017 22:56:05 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id C4AB7160BDA
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 26 Oct 2017 00:56:04 +0200 (CEST)
Received: (qmail 7852 invoked by uid 500); 25 Oct 2017 22:56:03 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 7841 invoked by uid 99); 25 Oct 2017 22:56:03 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Oct 2017 22:56:03 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 2CFD2DFC25; Wed, 25 Oct 2017 22:56:01 +0000 (UTC)
From: ilooner <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-984-drill@git.apache.org>
In-Reply-To: <git-pr-984-drill@git.apache.org>
Subject: [GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...
Content-Type: text/plain
Message-Id: <20171025225602.2CFD2DFC25@git1-us-west.apache.org>
Date: Wed, 25 Oct 2017 22:56:01 +0000 (UTC)
archived-at: Wed, 25 Oct 2017 22:56:05 -0000

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r147008923
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java ---
    @@ -59,48 +58,48 @@ public void withDistribution() throws Exception {
         test("alter session set `planner.slice_target` = 1");
         test("alter session set `store.partition.hash_distribute` = true");
         test("use dfs_test.tmp");
    -    test(String.format("create table orders_distribution partition by (o_orderpriority) as select * from dfs_test.`%s/multilevel/parquet`", TEST_RES_PATH));
    +    test("create table orders_distribution partition by (o_orderpriority) as select * from dfs_test.`/multilevel/parquet`");
         String query = "select * from orders_distribution where o_orderpriority = '1-URGENT'";
    -    testExcludeFilter(query, 1, "Filter", 24);
    +    testExcludeFilter(query, 1, "Filter\\(", 24);
    --- End diff --
    
    It is no longer sufficient to match "Filter" because the test class name contains "Filter" and the test class name is used to create the tmp directory. And the fully qualified path of a queried file is included in the plan. We want to only match the <b>Filter</b> steps generated in the plan, not the <b>Filters</b> in our file paths. In order to do this I tell it to match "Filter(" which corresponds to a filter step in the plan.


---