Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: arina-ielchiieva <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-928-drill@git.apache.org>
In-Reply-To: <git-pr-928-drill@git.apache.org>
Subject: [GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation
Content-Type: text/plain
Message-Id: <20171005152747.711DEF5C9E@git1-us-west.apache.org>
Date: Thu,  5 Oct 2017 15:27:47 +0000 (UTC)
archived-at: Thu, 05 Oct 2017 15:27:51 -0000

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/928#discussion_r142719680
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/QueryQueue.java ---
    @@ -0,0 +1,140 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.work.foreman.rm;
    +
    +import org.apache.drill.exec.proto.UserBitShared.QueryId;
    +
    +/**
    + * Interface which defines a queue implementation for query queues.
    + * Implementations can queue locally, queue distributed, or do
    + * nothing at all.
    + * <p>
    + * A queue can report itself as enabled or disabled. When enabled,
    + * all queries must obtain a lease prior to starting execution. The
    + * lease must be released at the completion of execution.
    + */
    +
    +public interface QueryQueue {
    +
    +  /**
    +   * The opaque lease returned once a query is admitted
    +   * for execution.
    +   */
    +
    +  public interface QueueLease {
    +    long queryMemoryPerNode();
    +
    +    /**
    +     * Release a query lease obtained from {@link #queue(QueryId, double))}.
    +     * Should be called by the per-query resource manager.
    +     *
    +     * @param lease the lease to be released.
    +     */
    +
    +    void release();
    +
    +    String queueName();
    +  };
    +
    +  /**
    +   * Exception thrown if a query exceeds the configured wait time
    +   * in the query queue.
    +   */
    +
    +  @SuppressWarnings("serial")
    +  public class QueueTimeoutException extends Exception {
    +
    +    private QueryId queryId;
    --- End diff --
    
    final?


---