drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin
Date Mon, 30 Oct 2017 13:24:49 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/774#discussion_r147583417
  
    --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/query/DBQuery.java
---
    @@ -0,0 +1,108 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.openTSDB.client.query;
    +
    +import java.util.HashSet;
    +import java.util.Set;
    +
    +import static org.apache.drill.exec.store.openTSDB.Constants.DEFAULT_TIME;
    +
    +/**
    + * DBQuery is an abstraction of an openTSDB query,
    + * that used for extracting data from the storage system by POST request to DB.
    + * <p>
    + * An OpenTSDB query requires at least one sub query,
    + * a means of selecting which time series should be included in the result set.
    + */
    +public class DBQuery {
    +
    +  /**
    +   * The start time for the query. This can be a relative or absolute timestamp.
    +   */
    +  private String start;
    +  /**
    +   * One or more sub subQueries used to select the time series to return.
    +   */
    +  private Set<Query> queries;
    +
    +  private DBQuery(Builder builder) {
    +    this.start = builder.start;
    +    this.queries = builder.queries;
    +  }
    +
    +  public String getStart() {
    +    return start;
    +  }
    +
    +  public Set<Query> getQueries() {
    +    return queries;
    +  }
    +
    +  public static class Builder {
    +
    +    private String start = DEFAULT_TIME;
    +    private Set<Query> queries = new HashSet<>();
    --- End diff --
    
    So what will happen is queries object will be empty? If eventually we will fail, maybe
it's better to fail in `Builder`?


---

Mime
View raw message