drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin
Date Mon, 30 Oct 2017 13:24:46 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/774#discussion_r146134207
  
    --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/services/ServiceImpl.java
---
    @@ -0,0 +1,176 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.openTSDB.client.services;
    +
    +import org.apache.drill.exec.store.openTSDB.client.OpenTSDB;
    +import org.apache.drill.exec.store.openTSDB.client.OpenTSDBTypes;
    +import org.apache.drill.exec.store.openTSDB.client.Service;
    +import org.apache.drill.exec.store.openTSDB.client.query.DBQuery;
    +import org.apache.drill.exec.store.openTSDB.client.query.Query;
    +import org.apache.drill.exec.store.openTSDB.dto.ColumnDTO;
    +import org.apache.drill.exec.store.openTSDB.dto.MetricDTO;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import retrofit2.Retrofit;
    +import retrofit2.converter.jackson.JacksonConverterFactory;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import static org.apache.drill.exec.store.openTSDB.Constants.AGGREGATOR;
    +import static org.apache.drill.exec.store.openTSDB.Constants.DOWNSAMPLE;
    +import static org.apache.drill.exec.store.openTSDB.Constants.METRIC;
    +import static org.apache.drill.exec.store.openTSDB.Util.isTableNameValid;
    +import static org.apache.drill.exec.store.openTSDB.Util.parseFROMRowData;
    +
    +public class ServiceImpl implements Service {
    +
    +  private static final Logger log =
    +      LoggerFactory.getLogger(ServiceImpl.class);
    +
    +  private OpenTSDB client;
    +  private Map<String, String> queryParameters;
    +
    +  public ServiceImpl(String connectionURL) {
    +    this.client = new Retrofit.Builder()
    +        .baseUrl(connectionURL)
    +        .addConverterFactory(JacksonConverterFactory.create())
    +        .build()
    +        .create(OpenTSDB.class);
    +  }
    +
    +  @Override
    +  public Set<MetricDTO> getTablesFromDB() {
    +    return getAllMetricsByTags();
    +  }
    +
    +  @Override
    +  public Set<String> getAllTableNames() {
    +    return getTableNames();
    +  }
    +
    +  @Override
    +  public List<ColumnDTO> getUnfixedColumnsToSchema() {
    +    Set<MetricDTO> tables = getAllMetricsByTags();
    +    List<ColumnDTO> unfixedColumns = new ArrayList<>();
    +
    +    for (MetricDTO table : tables) {
    +      for (String tag : table.getTags().keySet()) {
    +        ColumnDTO tmp = new ColumnDTO(tag, OpenTSDBTypes.STRING);
    +        if (!unfixedColumns.contains(tmp)) {
    +          unfixedColumns.add(tmp);
    +        }
    +      }
    +    }
    +    return unfixedColumns;
    +  }
    +
    +  @Override
    +  public void setupQueryParameters(String rowData) {
    +    if (!isTableNameValid(rowData)) {
    +      this.queryParameters = parseFROMRowData(rowData);
    +    } else {
    +      Map<String, String> params = new HashMap<>();
    +      params.put(METRIC, rowData);
    +      this.queryParameters = params;
    +    }
    +  }
    +
    +  private Set<MetricDTO> getAllMetricsByTags() {
    +    try {
    +      return getAllMetricsFromDBByTags();
    +    } catch (IOException e) {
    +      logIOException(e);
    +      return Collections.emptySet();
    +    }
    +  }
    +
    +  private Set<String> getTableNames() {
    +    try {
    +      return client.getAllTablesName().execute().body();
    +    } catch (IOException e) {
    +      e.printStackTrace();
    +      return Collections.emptySet();
    +    }
    +  }
    +
    +  private Set<MetricDTO> getAllTablesWithSpecialTag(DBQuery base) throws IOException
{
    +    return client.getTables(base).execute().body();
    +  }
    +
    +  private Set<MetricDTO> getAllMetricsFromDBByTags() throws IOException {
    +    Map<String, String> tags = new HashMap<>();
    +
    +    Query subQuery = new Query.Builder(queryParameters.get(METRIC))
    +        .setAggregator(queryParameters.get(AGGREGATOR))
    +        .setDownsample(queryParameters.get(DOWNSAMPLE))
    +        .setTags(tags).build();
    +
    +    Set<Query> queries = new HashSet<>();
    +    queries.add(subQuery);
    +
    +    DBQuery baseQuery = new DBQuery.Builder()
    +        .setQueries(queries)
    +        .build();
    +
    +    Set<MetricDTO> tables =
    +        getBaseTables(baseQuery);
    +
    +    Set<String> extractedTags =
    +        getTagsFromTables(tables);
    +
    +    tables.clear();
    +
    +    for (String value : extractedTags) {
    +      transformTagsForRequest(tags, value);
    +      tables.addAll(getAllTablesWithSpecialTag(baseQuery));
    +    }
    +    return tables;
    +  }
    +
    +  private Set<MetricDTO> getBaseTables(DBQuery base) throws IOException {
    +    return getAllTablesWithSpecialTag(base);
    +  }
    +
    +  private Set<String> getTagsFromTables(Set<MetricDTO> tables) {
    +    Set<String> extractedTags = new HashSet<>();
    +
    +    for (MetricDTO table : tables) {
    +      extractedTags.addAll(table.getAggregateTags());
    +      extractedTags.addAll(table.getTags().keySet());
    +    }
    +
    +    return extractedTags;
    +  }
    +
    +  private void transformTagsForRequest(Map<String, String> tags, String value)
{
    +    tags.clear();
    +    tags.put(value, "*");
    +  }
    +
    +  private void logIOException(IOException e) {
    +    log.warn("A problem occurred when talking to the server", e);
    --- End diff --
    
    That definitely should not be a warn and rather returning meaningful error to the user.


---

Mime
View raw message