drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...
Date Thu, 26 Oct 2017 18:33:46 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r147229627
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java
---
    @@ -76,43 +78,50 @@
       //        - detecting corrupt values must be deferred to actual data page reading
       //    - one from 1.4, where there is a proper created-by, but the corruption is present
       private static final String MIXED_CORRUPTED_AND_CORRECT_DATES_PATH =
    -      "[WORKING_PATH]/src/test/resources/parquet/4203_corrupt_dates/mixed_drill_versions";
    +      "/parquet/4203_corrupt_dates/mixed_drill_versions";
       // partitioned with 1.2.0, no certain metadata that these were written with Drill
       // the value will be checked to see that they look corrupt and they will be corrected
       // by default. Users can use the format plugin option autoCorrectCorruptDates to disable
       // this behavior if they have foreign parquet files with valid rare date values that
are
       // in the similar range as Drill's corrupt values
    +  private static final String PARTITIONED_1_2_FOLDER = "partitioned_with_corruption_4203_1_2";
       private static final String CORRUPTED_PARTITIONED_DATES_1_2_PATH =
    -      "[WORKING_PATH]/src/test/resources/parquet/4203_corrupt_dates/partitioned_with_corruption_4203_1_2";
    +      Paths.get("/parquet/4203_corrupt_dates", PARTITIONED_1_2_FOLDER).toString();
    --- End diff --
    
    Updated all paths to be relative in the tests


---

Mime
View raw message