drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prasadns14 <...@git.apache.org>
Subject [GitHub] drill pull request #1005: DRILL-5896: Handle HBase columns vector creation i...
Date Thu, 26 Oct 2017 04:12:59 GMT
Github user prasadns14 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1005#discussion_r147042366
  
    --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
---
    @@ -121,16 +125,18 @@ public HBaseRecordReader(Connection connection, HBaseSubScan.HBaseSubScanSpec
su
             byte[] family = root.getPath().getBytes();
             transformed.add(SchemaPath.getSimplePath(root.getPath()));
             PathSegment child = root.getChild();
    -        if (!completeFamilies.contains(new String(family, StandardCharsets.UTF_8).toLowerCase()))
{
    -          if (child != null && child.isNamed()) {
    -            byte[] qualifier = child.getNameSegment().getPath().getBytes();
    +        if (child != null && child.isNamed()) {
    +          byte[] qualifier = child.getNameSegment().getPath().getBytes();
    +          hbaseScan1.addColumn(family, qualifier);
    +          if (!completeFamilies.contains(new String(family, StandardCharsets.UTF_8)))
{
    --- End diff --
    
    Fixed


---

Mime
View raw message