drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...
Date Mon, 23 Oct 2017 21:05:11 GMT
Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1001#discussion_r146388018
  
    --- Diff: exec/java-exec/src/main/codegen/templates/CastFunctionsSrcVarLenTargetVarLen.java
---
    @@ -73,6 +73,9 @@ public void eval() {
         out.start =  in.start;
         if (charCount <= length.value || length.value == 0 ) {
           out.end = in.end;
    +      if (charCount == (out.end - out.start)) {
    +        out.asciiMode = org.apache.drill.exec.expr.holders.VarCharHolder.CHAR_MODE_IS_ASCII;
// we can conclude this string is ASCII
    --- End diff --
    
    can you please add comments here ? I am not able to understand this change. 


---

Mime
View raw message