drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...
Date Thu, 19 Oct 2017 21:20:41 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r145827440
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java ---
    @@ -64,9 +73,9 @@ public void testJoinWithLimit() throws Exception{
             "  nations.N_NAME,\n" +
             "  regions.R_NAME\n" +
             "FROM\n" +
    -        "  dfs_test.`[WORKING_PATH]/../../sample-data/nation.parquet` nations\n" +
    +        "  dfs.`/sample-data/nation.parquet` nations\n" +
    --- End diff --
    
    I accidentally changed it to dfs, will switch it back to dfs_test for consistency. <b>dfs</b>
and <b>dfs_test>/b> are configured to point to the same temp directories so they
are in fact interchangeable. This configuration happens in the openClient method of BaseTestQuery
and in the configureStoragePlugins method of the ClusterFixture. 
    
    Throughout making this change I was scratching my head as to why <b>dfs_test</b>
is used instead of <b>dfs<b>. After going through the code I don't see any reason
as to why dfs_test was created in the first place. I think we should actually remove <b>dfs_test</b>
and just use <b>dfs</b> everywhere for uniformity. I'll go ahead and do that now.


---

Mime
View raw message