drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prasadns14 <...@git.apache.org>
Subject [GitHub] drill pull request #998: DRILL-5887: Display process user/groups info in Dri...
Date Thu, 19 Oct 2017 01:47:50 GMT
Github user prasadns14 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/998#discussion_r145584179
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
    @@ -85,21 +86,33 @@ public ClusterInfo getClusterInfoJSON() {
         // For all other cases the user info need-not or should-not be displayed
         OptionManager optionManager = work.getContext().getOptionManager();
         final boolean isUserLoggedIn = AuthDynamicFeature.isUserLoggedIn(sc);
    +    final String processUser = isUserLoggedIn ?
    +            ImpersonationUtil.getProcessUserName() : null;
    --- End diff --
    
    From security perspective it would be good to display process user only if an admin user
is logged in. Removed the check here as the condition is handled in html.


---

Mime
View raw message