drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #993: DRILL-5874: NPE in AnonWebUserConnection.cleanupSes...
Date Wed, 18 Oct 2017 23:47:52 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/993#discussion_r145495729
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
---
    @@ -204,9 +217,15 @@ public WebUserConnection provide() {
                     config.getLong(ExecConstants.HTTP_SESSION_MEMORY_RESERVATION),
                     config.getLong(ExecConstants.HTTP_SESSION_MEMORY_MAXIMUM));
     
    +        // Create a dummy close future which is needed by Foreman only. Foreman uses
this future to add a close
    +        // listener to known about channel close event from underlying layer. We use
this future to notify Foreman
    +        // listeners when the Web connection between Web Client and WebServer is closed.
This will help Foreman to cancel
    +        // all the running queries for this Web Client.
    --- End diff --
    
    We are using [web session](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java#L193)
concept for Drill's WebServer.


---

Mime
View raw message