drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...
Date Wed, 18 Oct 2017 22:23:42 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r144935089
  
    --- Diff: common/src/main/java/org/apache/drill/common/util/TestTools.java ---
    @@ -17,15 +17,28 @@
      */
     package org.apache.drill.common.util;
     
    +import java.io.File;
    +import java.io.IOException;
     import java.nio.file.Paths;
     
    +import org.apache.commons.io.FileUtils;
     import org.junit.rules.TestName;
     import org.junit.rules.TestRule;
     import org.junit.rules.Timeout;
     
    +import static org.apache.drill.common.util.TestTools.DataType.PROJECT;
    +import static org.apache.drill.common.util.TestTools.DataType.RESOURCE;
    +
     public class TestTools {
       // private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(TestTools.class);
     
    +  public enum DataType {
    --- End diff --
    
    `ResourceType`? `FileType`? `FileSource`? `ResourceScope`?
    
    This is a symbolic reference to a resource root, not really a kind of a data item...


---

Mime
View raw message