drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...
Date Wed, 18 Oct 2017 22:23:40 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r144936994
  
    --- Diff: common/src/test/java/org/apache/drill/test/DirTestWatcher.java ---
    @@ -32,23 +32,50 @@
     public class DirTestWatcher extends TestWatcher {
       private String dirPath;
       private File dir;
    +  private boolean deleteDirAtEnd = true;
    --- End diff --
    
    Thanks for the Javadoc added previously. Perhaps add a section on how to use this class.
If I need a test directory, do I create an instance of this class? Or, does JUnit do it for
me? If done automagically, how do I get a copy of the directory?
    
    If this is explained in JUnit, perhaps just reference that information. Even better would
be a short example:
    
    > To get a test directory:
    ```
        // Do something here
        File myDir = // do something
    ```


---

Mime
View raw message