drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #993: DRILL-5874: NPE in AnonWebUserConnection.cleanupSes...
Date Mon, 16 Oct 2017 18:33:02 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/993#discussion_r144930573
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/WebSessionResourcesTest.java
---
    @@ -0,0 +1,146 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.server.rest;
    +
    +import io.netty.channel.ChannelPromise;
    +import io.netty.channel.DefaultChannelPromise;
    +import io.netty.util.concurrent.EventExecutor;
    +import io.netty.util.concurrent.Future;
    +import io.netty.util.concurrent.GenericFutureListener;
    +import org.apache.drill.exec.memory.BufferAllocator;
    +import org.apache.drill.exec.rpc.TransportCheck;
    +import org.apache.drill.exec.rpc.user.UserSession;
    +import org.junit.Test;
    +
    +import java.net.SocketAddress;
    +import java.util.concurrent.CountDownLatch;
    +
    +import static org.junit.Assert.assertTrue;
    +import static org.junit.Assert.fail;
    +import static org.mockito.Matchers.any;
    +import static org.mockito.Mockito.mock;
    +import static org.mockito.Mockito.verify;
    +
    +public class WebSessionResourcesTest {
    +  //private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(WebSessionResourcesTest.class);
    +
    +  private WebSessionResources webSessionResources;
    +
    +  private boolean listenerComplete;
    +
    +  private CountDownLatch latch;
    +
    +  private EventExecutor executor;
    +
    +
    --- End diff --
    
    Maybe a comment to explain what this test is, in fact, testing? If the mechanism itself
is explained elsewhere, simply reference that with a \@see or \@link tag.


---

Mime
View raw message