drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #973: DRILL-5775: Select * query on a maprdb binary table...
Date Wed, 11 Oct 2017 20:20:53 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/973#discussion_r144124764
  
    --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseUtils.java
---
    @@ -139,4 +142,26 @@ public static Filter orFilterAtIndex(Filter currentFilter, int index,
Filter new
         return Bytes.compareTo(left, right) < 0 ? left : right;
       }
     
    +
    +  /**
    +   * Verify the presence of a column family in the schema path of the hbase table or
whether the schema path is
    +   * the row key column.
    +   *
    +   * @param columns List of the selected columns
    +   * @param hTableDesc HTableDescriptor of HBase/MapR-DB_binary table (consists the details
about that table)
    +   * @throws DrillRuntimeException if column family does not exist, or is not row_key
column.
    +   */
    +  public static void verifyColumns(List<SchemaPath> columns, HTableDescriptor hTableDesc)
{
    --- End diff --
    
    As it turns out, this PR is introducing the very ambiguity that DRILL-5830 tried to remove
from DRILL-5546. That is, we now have to separate ways to expand the wildcard: this way and
the project push down way. We need this commit, so we'll accept this for now. But, moving
forward, we should clear up this ambiguity.


---

Mime
View raw message