drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #973: DRILL-5775: Select * query on a maprdb binary table...
Date Wed, 11 Oct 2017 12:11:48 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/973#discussion_r143980497
  
    --- Diff: contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/binary/MapRDBBinaryTable.java
---
    @@ -0,0 +1,48 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.mapr.db.binary;
    +
    +import java.io.IOException;
    +
    +import org.apache.drill.common.exceptions.UserException;
    +import org.apache.drill.exec.store.dfs.FileSystemPlugin;
    +import org.apache.drill.exec.store.dfs.FormatSelection;
    +import org.apache.drill.exec.store.hbase.AbstractHBaseDrillTable;
    +import org.apache.drill.exec.store.mapr.TableFormatPlugin;
    +import org.apache.drill.exec.store.mapr.db.MapRDBFormatPlugin;
    +import org.apache.hadoop.hbase.TableName;
    +import org.apache.hadoop.hbase.client.Admin;
    +
    +public class MapRDBBinaryTable extends AbstractHBaseDrillTable {
    +  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(MapRDBBinaryTable.class);
    +
    +  public MapRDBBinaryTable(String storageEngineName, FileSystemPlugin storagePlugin,
TableFormatPlugin formatPlugin,
    +      FormatSelection selection) {
    +    super(storageEngineName, storagePlugin, selection);
    +    String tableName = selection.getSelection().getFiles().get(0);
    --- End diff --
    
    Very good suggestions! Done. Thanks.


---

Mime
View raw message