drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #971: Drill-5834 Add Networking Functions
Date Wed, 11 Oct 2017 09:39:32 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/971#discussion_r143950087
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNetworkFunctions.java
---
    @@ -0,0 +1,93 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.drill.exec.fn.impl;
    +
    +import org.apache.drill.BaseTestQuery;
    +import org.junit.Test;
    +
    +public class TestNetworkFunctions extends BaseTestQuery {
    +
    +  @Test
    +  public void testInetAton() throws Exception {
    +    final String query = "select inet_aton( '192.168.0.1') as inet from (values(1))";
    +    testBuilder().sqlQuery(query).ordered().baselineColumns("inet").baselineValues( Long.parseLong("3232235521")
).go();
    +  }
    +
    +  @Test
    +  public void testInetNtoa() throws Exception {
    +    final String query = "select inet_ntoa( 3232235521 ) as inet from (values(1))";
    +    testBuilder().sqlQuery(query).ordered().baselineColumns("inet").baselineValues("192.168.0.1").go();
    +  }
    +
    +  @Test
    +  public void testInNetwork() throws Exception {
    +    final String query = "select in_network( '192.168.0.1', '192.168.0.0/28' ) as in_net
FROM (values(1))";
    --- End diff --
    
    What about negative test case?


---

Mime
View raw message