drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #982: Fixed queued time calculation
Date Tue, 10 Oct 2017 16:28:12 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/982#discussion_r143781691
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/DistributedQueryQueue.java
---
    @@ -273,9 +273,8 @@ public QueueLease enqueue(QueryId queryId, double cost) throws QueryQueueExcepti
         }
     
         if (lease == null) {
    -      int timeoutSecs = (int) Math.round(configSet.queueTimeout/1000.0);
    -      logger.warn("Queue timeout: {} after {} seconds.", queueName, timeoutSecs);
    -      throw new QueueTimeoutException(queryId, queueName, timeoutSecs);
    +      logger.warn("Queue timeout: {} after {} ms.", queueName, configSet.queueTimeout);
    --- End diff --
    
    This was actually not wrong. Instead, it mapped the number from the internal ms units
into more user-friendly units of seconds. That is, it is more useful to see:
    
    Queue timeout: small after 60 seconds
    
    Than:
    
    Queue timeout: small after 60000 ms.
    
    If we do want to use ms. perhaps format them with commas:
    
    Queue timeout: small after 60,000 ms.
    
    Or show both:
    
    Queue timeout: small after 60,000 ms. (60 seconds)


---

Mime
View raw message