drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #974: DRILL-5839: Handle Empty Batches in Merge Receiver
Date Thu, 05 Oct 2017 20:38:19 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/974#discussion_r143049947
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockRecordReader.java
---
    @@ -52,7 +52,7 @@ public MockRecordReader(FragmentContext context, MockScanEntry config)
{
     
       private int getEstimatedRecordSize(MockColumn[] types) {
         int x = 0;
    -    for (int i = 0; i < types.length; i++) {
    +    for (int i = 0; i < (types == null ? 0 : types.length); i++) {
    --- End diff --
    
    Nit: maybe use:
    
    ```
    if (types == null) { return 0; }
    // Original code here..
    ```


---

Mime
View raw message