drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #950: DRILL-5431: SSL Support
Date Thu, 05 Oct 2017 08:11:53 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r142862510
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java ---
    @@ -49,12 +64,19 @@ public void testMissingKeystorePassword() throws Exception {
         ConfigBuilder config = new ConfigBuilder();
         config.put(ExecConstants.HTTP_KEYSTORE_PATH, "/root");
         config.put(ExecConstants.HTTP_KEYSTORE_PASSWORD, "");
    +    config.put(ExecConstants.SSL_USE_HADOOP_CONF, false);
    +    config.put(ExecConstants.USER_SSL_ENABLED, true);
         try {
    -      SSLConfig sslv = new SSLConfig(config.build());
    +      SSLConfig sslv = new SSLConfigBuilder()
    +          .config(config.build())
    +          .mode(SSLFactory.Mode.SERVER)
    +          .initializeSSLContext(false)
    +          .validateKeyStore(true)
    +          .build();
           fail();
           //Expected
         } catch (Exception e) {
    -      assertTrue(e instanceof DrillException);
    +
    --- End diff --
    
    But the assert `assertTrue(e instanceof DrillException);` was removed and catch block
is empty, test will never fail...


---

Mime
View raw message