Return-Path: <dev-return-31586-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 064DE200D04
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 11 Sep 2017 23:46:16 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 046491609C4; Mon, 11 Sep 2017 21:46:16 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 4AA5E1609B7
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 11 Sep 2017 23:46:15 +0200 (CEST)
Received: (qmail 4309 invoked by uid 500); 11 Sep 2017 21:46:13 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 4298 invoked by uid 99); 11 Sep 2017 21:46:12 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Sep 2017 21:46:12 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 6B914F5769; Mon, 11 Sep 2017 21:46:12 +0000 (UTC)
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-930-drill@git.apache.org>
In-Reply-To: <git-pr-930-drill@git.apache.org>
Subject: [GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...
Content-Type: text/plain
Message-Id: <20170911214612.6B914F5769@git1-us-west.apache.org>
Date: Mon, 11 Sep 2017 21:46:12 +0000 (UTC)
archived-at: Mon, 11 Sep 2017 21:46:16 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/930#discussion_r138200345
  
    --- Diff: common/src/test/resources/logback-test.xml ---
    @@ -0,0 +1,111 @@
    +<?xml version="1.0" encoding="UTF-8" ?>
    +<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
    +  license agreements. See the NOTICE file distributed with this work for additional
    +  information regarding copyright ownership. The ASF licenses this file to
    +  You under the Apache License, Version 2.0 (the "License"); you may not use
    +  this file except in compliance with the License. You may obtain a copy of
    +  the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
    +  by applicable law or agreed to in writing, software distributed under the
    +  License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
    +  OF ANY KIND, either express or implied. See the License for the specific
    +  language governing permissions and limitations under the License. -->
    +<configuration>
    +
    +  <if condition='property("drill.lilith.enable").equalsIgnoreCase("true")'>
    +    <then>
    +      <appender name="SOCKET" class="de.huxhorn.lilith.logback.appender.ClassicMultiplexSocketAppender">
    +        <Compressing>true</Compressing>
    +        <ReconnectionDelay>10000</ReconnectionDelay>
    +        <IncludeCallerData>true</IncludeCallerData>
    +        <RemoteHosts>${LILITH_HOSTNAME:-localhost}</RemoteHosts>
    +      </appender>
    +    </then>
    +  </if>
    +
    +  <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
    +    <!-- encoders are assigned the type
    +         ch.qos.logback.classic.encoder.PatternLayoutEncoder by default -->
    +    <encoder>
    +      <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
    +    </encoder>
    +  </appender>
    +
    +  <!--
    +  <appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
    +    <file>${log.path}</file>
    +    <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
    +      <fileNamePattern>${log.path}.%i</fileNamePattern>
    +      <minIndex>1</minIndex>
    +      <maxIndex>10</maxIndex>
    +    </rollingPolicy>
    +
    +    <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
    +      <maxFileSize>100MB</maxFileSize>
    +    </triggeringPolicy>
    +    <encoder>
    +      <pattern>%date{ISO8601} [%thread] %-5level %logger{36} - %msg%n</pattern>
    +    </encoder>
    +  </appender>
    +  -->
    +
    +  <logger name="org.apache.drill" additivity="false">
    +    <level value="debug"/>
    --- End diff --
    
    OK.


---