Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-923-drill@git.apache.org>
In-Reply-To: <git-pr-923-drill@git.apache.org>
Subject: [GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...
Content-Type: text/plain
Message-Id: <20170910003333.7C3BFF571F@git1-us-west.apache.org>
Date: Sun, 10 Sep 2017 00:33:32 +0000 (UTC)
archived-at: Sun, 10 Sep 2017 00:33:43 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r137937991
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/RestClientFixture.java ---
    @@ -0,0 +1,117 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.drill.test;
    +
    +import com.google.common.base.Preconditions;
    +import org.apache.drill.exec.ExecConstants;
    +import org.apache.drill.exec.server.rest.StatusResources;
    +import org.glassfish.jersey.client.ClientConfig;
    +import org.glassfish.jersey.client.JerseyClientBuilder;
    +
    +import javax.annotation.Nullable;
    +import javax.ws.rs.client.Client;
    +import javax.ws.rs.client.WebTarget;
    +import javax.ws.rs.core.GenericType;
    +import javax.ws.rs.core.MediaType;
    +
    +import java.util.List;
    +
    +/**
    + * Represents a client for the Drill Rest API.
    + */
    +public class RestClientFixture implements AutoCloseable {
    +  /**
    +   * A builder for the rest client.
    +   */
    +  public static class Builder {
    +    private ClusterFixture cluster;
    +
    +    public Builder(ClusterFixture cluster) {
    +      this.cluster = Preconditions.checkNotNull(cluster);
    +    }
    +
    +    public RestClientFixture build() {
    +      return new RestClientFixture(cluster);
    +    }
    +  }
    +
    +  private WebTarget baseTarget;
    +  private Client client;
    --- End diff --
    
    `final` here and above?


---