Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: ppadma <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-928-drill@git.apache.org>
In-Reply-To: <git-pr-928-drill@git.apache.org>
Subject: [GitHub] drill pull request #928: Drill 5716: Queue-driven memory allocation
Content-Type: text/plain
Message-Id: <20170901053703.1FEF7F5613@git1-us-west.apache.org>
Date: Fri,  1 Sep 2017 05:37:03 +0000 (UTC)
archived-at: Fri, 01 Sep 2017 05:37:07 -0000

Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/928#discussion_r136491938
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/ResourceManager.java ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.work.foreman.rm;
    +
    +import org.apache.drill.exec.ops.QueryContext;
    +import org.apache.drill.exec.work.foreman.Foreman;
    +
    +/**
    + * Drillbit-wide resource manager shared by all queries. Manages
    + * memory (at present) and CPU (planned). Since queries are the
    + * primary consumer of resources, manages resources by throttling
    + * queries into the system, and allocating resources to queries
    + * in order to control total use. An "null" implementation handles the
    + * case of no queuing. Clearly, the null case cannot effectively control
    + * resource use.
    + */
    +
    +public interface ResourceManager {
    +
    +  /**
    +   * Returns the memory, in bytes, assigned to each node in a Drill
    +   * cluster. Since Drill nodes are symmetrical, knowing he memory on
    --- End diff --
    
    better is to say "assumed" to be symmetrical or "expected" to be symmetrical :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---