drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #950: DRILL-5431: SSL Support
Date Wed, 27 Sep 2017 05:57:47 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r141228991
  
    --- Diff: contrib/native/client/src/include/drill/userProperties.hpp ---
    @@ -0,0 +1,73 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#ifndef USER_PROPERTIES_H
    +#define USER_PROPERTIES_H
    +
    +#include <map>
    +#include "drill/common.hpp"
    +
    +namespace Drill{
    +
    +class DECLSPEC_DRILL_CLIENT DrillUserProperties{
    +    public:
    +        static const std::map<std::string, uint32_t> USER_PROPERTIES;
    +
    +        DrillUserProperties(){};
    +
    +        void setProperty( const std::string& propName, const std::string& propValue){
    --- End diff --
    
    so for each `propName` we have defined if it's `string/boolean/etc`. How about checking
here if `propName` is boolean then make sure to set the value in lower case? So when we retrieve
those values and compare with string "true" or "false", we don't have to do the translation.


---

Mime
View raw message