drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #962: DRILL-5820: Add support for libpam4j Pam Authentica...
Date Tue, 26 Sep 2017 22:12:42 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/962#discussion_r141199041
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/PamUserAuthenticator.java
---
    @@ -59,7 +59,8 @@ public void authenticate(String user, String password) throws UserAuthentication
         for (String pamProfile : profiles) {
           Pam pam = new Pam(pamProfile);
           if (!pam.authenticateSuccessful(user, password)) {
    -        throw new UserAuthenticationException(String.format("PAM profile '%s' validation
failed", pamProfile));
    +        throw new UserAuthenticationException(String.format("PAM profile '%s' validation
failed for user %s",
    --- End diff --
    
    The module above throws an exception. Here we get a `boolean`. Does this mean that the
exception was mapped to `false`, then mapped back to an exception?


---

Mime
View raw message