drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #950: DRILL-5431: SSL Support
Date Mon, 25 Sep 2017 17:26:31 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r140603240
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -110,6 +110,18 @@
       String HASHAGG_FALLBACK_ENABLED_KEY = "drill.exec.hashagg.fallback.enabled";
       BooleanValidator HASHAGG_FALLBACK_ENABLED_VALIDATOR = new BooleanValidator(HASHAGG_FALLBACK_ENABLED_KEY);
     
    +  String SSL_PROVIDER = "drill.exec.ssl.provider"; // valid values are "JDK", "OPENSSL"
// default JDK
    +  String SSL_PROTOCOL = "drill.exec.ssl.protocol"; // valid values are SSL, SSLV2, SSLV3,
TLS, TLSV1, TLSv1.1, TLSv1.2(default)
    +  String SSL_KEYSTORE_TYPE = "drill.exec.ssl.keyStoreType";
    +  String SSL_KEYSTORE_PATH = "drill.exec.ssl.keyStorePath";     // path to keystore.
default : $JRE_HOME/lib/security/keystore.jks
    +  String SSL_KEYSTORE_PASSWORD = "drill.exec.ssl.keyStorePassword"; // default: changeit
    +  String SSL_KEY_PASSWORD = "drill.exec.ssl.keyPassword"; //
    +  String SSL_TRUSTSTORE_TYPE = "drill.exec.ssl.trustStoreType"; // valid values are jks(default),
jceks, pkcs12
    +  String SSL_TRUSTSTORE_PATH = "drill.exec.ssl.trustStorePath"; // path to keystore.
default : $JRE_HOME/lib/security/cacerts.jks
    +  String SSL_TRUSTSTORE_PASSWORD = "drill.exec.ssl.trustStorePassword"; // default: changeit
    +  String SSL_USE_HADOOP_CONF = "drill.exec.ssl.useHadoopConfig"; // Initialize ssl params
from hadoop if not provided by drill. default: true
    +  String SSL_HANDSHAKE_TIMEOUT = "drill.exec.security.user.encryption.ssl.handshakeTimeout";
// Default 10 seconds
    --- End diff --
    
    I'd like to leave these are they are. trustStoreType, trustStorePassword, etc are spelt
the same way in JDK and hadoop. 


---

Mime
View raw message