drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #950: DRILL-5431: SSL Support
Date Fri, 22 Sep 2017 21:31:43 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r140601194
  
    --- Diff: contrib/native/client/src/include/drill/common.hpp ---
    @@ -163,9 +170,13 @@ typedef enum{
     #define USERPROP_USERNAME "userName"
     #define USERPROP_PASSWORD "password"
     #define USERPROP_SCHEMA   "schema"
    -#define USERPROP_USESSL   "useSSL"        // Not implemented yet
    -#define USERPROP_FILEPATH "pemLocation"   // Not implemented yet
    -#define USERPROP_FILENAME "pemFile"       // Not implemented yet
    +#define USERPROP_USESSL   "enableTLS"
    +#define USERPROP_TLSPROTOCOL "TLSProtocol" //TLS version
    +#define USERPROP_CERTFILEPATH "certFilePath" // pem file path and name
    +#define USERPROP_CERTPASSWORD "certPassword" // Password for certificate file
    --- End diff --
    
    Commented it out. I'm leaving it there so it can be used when we implement support for
trust stores which may require passwords. 


---

Mime
View raw message