drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #950: DRILL-5431: SSL Support
Date Fri, 22 Sep 2017 03:46:32 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r140130050
  
    --- Diff: common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
    @@ -110,8 +110,8 @@ public static DrillConfig create() {
        *
        * @return {@link DrillConfig} instance
        */
    -  public static DrillConfig forClient() {
    -    return create(null, false);
    +  public static DrillConfig forClient(Properties props) {
    +    return create(null, props, false);
    --- End diff --
    
    This change is not required since this will duplicate the parameters passed by JDBC application
to DrillClient. We are passing that information using _info (Properties type object) in DrillConnectionImpl_


---

Mime
View raw message