drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #950: DRILL-5431: SSL Support
Date Fri, 22 Sep 2017 03:46:30 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r140124213
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -126,10 +138,10 @@
       String HTTP_SESSION_MEMORY_RESERVATION = "drill.exec.http.session.memory.reservation";
       String HTTP_SESSION_MEMORY_MAXIMUM = "drill.exec.http.session.memory.maximum";
       String HTTP_SESSION_MAX_IDLE_SECS = "drill.exec.http.session_max_idle_secs";
    -  String HTTP_KEYSTORE_PATH = "drill.exec.ssl.keyStorePath";
    -  String HTTP_KEYSTORE_PASSWORD = "drill.exec.ssl.keyStorePassword";
    -  String HTTP_TRUSTSTORE_PATH = "drill.exec.ssl.trustStorePath";
    -  String HTTP_TRUSTSTORE_PASSWORD = "drill.exec.ssl.trustStorePassword";
    +  String HTTP_KEYSTORE_PATH = SSL_KEYSTORE_PATH;
    +  String HTTP_KEYSTORE_PASSWORD = SSL_KEYSTORE_PASSWORD;
    +  String HTTP_TRUSTSTORE_PATH = SSL_TRUSTSTORE_PATH;
    +  String HTTP_TRUSTSTORE_PASSWORD = SSL_TRUSTSTORE_PASSWORD;
    --- End diff --
    
    Why not just keep _SSL_KEYSTORE_ and _SSL_TRUSTSTORE_ constants and remove the HTTP ones
?


---

Mime
View raw message