drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #938: DRILL-5694: Handle HashAgg OOM by spill and retry, ...
Date Wed, 20 Sep 2017 19:02:01 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/938#discussion_r140062742
  
    --- Diff: common/src/main/java/org/apache/drill/common/exceptions/UserException.java ---
    @@ -536,6 +542,33 @@ public Builder pushContext(final String name, final double value)
{
          * @return user exception
          */
         public UserException build(final Logger logger) {
    +
    +      // To allow for debugging:
    +      //     A spinner code to make the execution stop here while the file '/tmp/drillspin'
exists
    +      // Can be used to attach a debugger, use jstack, etc
    +      // The processID of the spinning thread should be in a file like /tmp/spin4148663301172491613.tmp
    +      // along with the error message.
    +      File spinFile = new File("/tmp/drillspin");
    --- End diff --
    
     Using a "flag file" instead of a config setting gives more flexibility; like no need
to restart in order to turn this feature on/off, or can select to catch errors only in few
nodes, and last -- can free the looping thread by deleting this "flag file". 
          I also plan on posting an announcement on the dev list about this new "feature",
and see if there's any feedback. 



---

Mime
View raw message