drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...
Date Wed, 13 Sep 2017 19:57:26 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/930#discussion_r138722693
  
    --- Diff: common/src/test/resources/logback-test.xml ---
    @@ -0,0 +1,92 @@
    +<?xml version="1.0" encoding="UTF-8" ?>
    +<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
    +  license agreements. See the NOTICE file distributed with this work for additional
    +  information regarding copyright ownership. The ASF licenses this file to
    +  You under the Apache License, Version 2.0 (the "License"); you may not use
    +  this file except in compliance with the License. You may obtain a copy of
    +  the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
    +  by applicable law or agreed to in writing, software distributed under the
    +  License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
    +  OF ANY KIND, either express or implied. See the License for the specific
    +  language governing permissions and limitations under the License. -->
    +<configuration>
    +
    +  <if condition='property("drill.lilith.enable").equalsIgnoreCase("true")'>
    +    <then>
    +      <appender name="SOCKET" class="de.huxhorn.lilith.logback.appender.ClassicMultiplexSocketAppender">
    +        <Compressing>true</Compressing>
    +        <ReconnectionDelay>10000</ReconnectionDelay>
    +        <IncludeCallerData>true</IncludeCallerData>
    +        <RemoteHosts>${LILITH_HOSTNAME:-localhost}</RemoteHosts>
    +      </appender>
    +    </then>
    +  </if>
    +
    +  <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
    +    <!-- encoders are assigned the type
    +         ch.qos.logback.classic.encoder.PatternLayoutEncoder by default -->
    +    <encoder>
    +      <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
    +    </encoder>
    +  </appender>
    +
    +  <!--
    --- End diff --
    
    +1 I think that developers are unlikely to use rolling file appender and can redirect
console to a file if necessary.


---

Mime
View raw message